fix(assets): fix getImage
options type
#12349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes #12319
As I mentioned in the issue, there are two ways of fixing the problem:
Omit
ting from types containing index signatures.ImageTransform
.I went with the first one since I guess that index signature was put there for a reason. :)
I also applied
Simplify
. This is to force TypeScript better resolve properties. Not doing that results in the following error when an empty options objects is passed togetImage
:With
Simplify
the error is:The latter is rather verbose, but I'd prefer this over the former's actually misleading message.
Testing
Not sure how to add non-fragile or hardcoded tests here.
Docs
This is a fix that doesn't require any changes in docs.