fix(core): computation of outDir for SSR builds

[ematipico]

Changes

Closes #12248
Closes PLT-2594

The bug was happening only for SSR builds.

Testing

Added a new test

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: 49a32e3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bluwy]

I don't know if we can fix this in main now. I discovered that it's kinda a breaking change if someone else relied on the old behaviour (for workaround reasons), that's why I sent the fix to next at #11916

[bluwy]

Blocking due to my previous comment

[ematipico]

I don't know if we can fix this in main now. I discovered that it's kinda a breaking change if someone else relied on the old behaviour (for workaround reasons), that's why I sent the fix to next at #11916

The issue is only for SSR, which means that it worked for SSG builds. I would agree with you if both were affected by the incorrect behaviour but in this case it's not.

Plus, I don't think we have ever suggested a workaround in our docs like we did for pagination

[bluwy]

I think there's still a chance we could break SSR adapters if we change this in main. We don't explicitly suggest a workaround, but it's the only workaround users can do when they're hit with this quirk and it goes unreported. And the behaviour had existed for a long while that it's as risky to fix now like the pagination fix.

It's probably safer to handle this in next so we don't cause potential regression now IMO.