Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use p-queue instead of fastq #12189

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Use p-queue instead of fastq #12189

merged 2 commits into from
Oct 11, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 11, 2024

Changes

Both libraries were very similar, but since we used p-queue in the past first, I switched to it.

Also, there's unused code that allows us to remove string-width dep.

Testing

Existing tests should pass

Docs

n/a

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 5db1467

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 11, 2024
@bluwy bluwy merged commit 2f5b28e into main Oct 11, 2024
13 of 14 checks passed
@bluwy bluwy deleted the use-p-queue branch October 11, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants