fix(routing): compute APIContext.params when rewriting using next
#12031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bce69d0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
approved these changes
Sep 19, 2024
Merged
|
Hi I encountered a problem with this changes, if you use the next(/.../) with a new context as parameter, cookies set in the page renderer won't come back in the response to the client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #11932
In order to fix the issue, I had to use a
Reflectin order to store private information insideAPIContext, so they could be used inside thesequenceAPI. We store thePipelineinstance, so we can gracefully cantryRewriteand get all the information needed to re-computeAPIContext.paramsAlso, I took the opportunity to remove
originalRoutefromtryRewritebecause it's not needed at all (it was left there by mistake).Testing
I added a new test
Docs
N/A