Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vitest in Astro 5 #12009

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix vitest in Astro 5 #12009

merged 2 commits into from
Sep 16, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Fixes Astro 5.0.0-alpha > 4 and Vitest fail #12007
  • The types in create-vite.ts were too loose, allowing a mistake where getVitestConfig was creating a vite instance with the dev server without the ssrManifest, which it expects to have.

Testing

  • Added a new vitest to the fixtures to act like a smoke test.

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: e27dd58

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 16, 2024
@matthewp matthewp merged commit f10a3b7 into next Sep 16, 2024
14 checks passed
@matthewp matthewp deleted the vitest-astro-5 branch September 16, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants