feat(next): TODOs #11987
feat(next): TODOs #11987
Conversation
🦋 Changeset detectedLatest commit: f79a6a5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
| @@ -228,7 +228,6 @@ export function createGetDataEntryById({ | |||
|
|
|||
| const lazyImport = await getEntryImport(collection, id); | |||
|
|
|||
| // TODO: AstroError | |||
There was a problem hiding this comment.
This will be removed in Astro 6.0, not worth doing it now
| @@ -12,7 +12,7 @@ export async function emitESMImage( | |||
| id: string | undefined, | |||
| /** @deprecated */ | |||
| _watchMode: boolean, | |||
| // FIX: in Astro 5, this function should not be passed in dev mode at all. | |||
| // FIX: in Astro 6, this function should not be passed in dev mode at all. | |||
There was a problem hiding this comment.
we won't get to this right now, it's.. tough
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.changeset/blue-sloths-stare.md
Outdated
| 'astro': patch | ||
| --- | ||
|
|
||
| App class now accepts renderOptions |
There was a problem hiding this comment.
Just checking, does this need updating in the docs here: https://docs.astro.build/en/reference/adapter-reference/#apprenderrequest-request-options-renderoptions and we should mention it in the upgrade guide as a Breaking Change
.changeset/blue-sloths-stare.md
Outdated
| 'astro': patch | ||
| --- | ||
|
|
||
| App class now accepts renderOptions |
There was a problem hiding this comment.
| App class now accepts renderOptions | |
| Adds a new `renderOptions` object for `App/class` |
Not sure about the syntax for App class, but it likely needs something!
There was a problem hiding this comment.
App is a class, this is for the render method. I'll update to something.
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
app.render()now takes 2 arguments instead of 3.Testing
Docs
renderOptionsis already the only documented way to useapp.render(): https://docs.astro.build/en/reference/adapter-reference/#server-entrypoint