-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default exclude to tsconfigs #11982
Conversation
🦋 Changeset detectedLatest commit: 66c67ce The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but 2 questions:
- do we need a changeset for that? (i guess so)
- should we update the
include
as well? with["${configDir}/.astro/types.d.ts", "${configDir}/**/*"]
Yeah, we can do the include as well, should be fine with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a major
changeset. A reviewer will merge this at the next release if approved.
With TS 5.5, we can now do this in our default templates. For users using lower versions, it just won't work. For users using any other dist dir, they'll want to update their own exclude anyway, overriding this. If someone has changed the default output, and has a
dist
folder that is not supposed to be ignored by TS (???) they can also override this in their own tsconfig.json.Testing
N/A
Docs
N/A