Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed DB token env vars #11894

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Fix mixed DB token env vars #11894

merged 5 commits into from
Sep 3, 2024

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Aug 31, 2024

Changes

Testing

  • Tested the combinations of the env vars

Docs

No docs change necessary.

@Fryuni Fryuni added the pkg: db label Aug 31, 2024
@Fryuni Fryuni self-assigned this Aug 31, 2024
Copy link

changeset-bot bot commented Aug 31, 2024

🦋 Changeset detected

Latest commit: b480c6e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot removed the pkg: db label Aug 31, 2024
@Fryuni Fryuni added - P4: important Violate documented behavior or significantly impacts performance (priority) pkg: db labels Sep 2, 2024
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you’re dbest

@github-actions github-actions bot removed the pkg: db label Sep 3, 2024
@Princesseuh Princesseuh merged commit cc820c5 into main Sep 3, 2024
13 checks passed
@Princesseuh Princesseuh deleted the fryuni/fix-libsql-db-link branch September 3, 2024 12:53
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASTRO_DB_APP_TOKEN environment variable not being recognized for Astro DB libSQL
3 participants