fix: pass config instead of settings to content layer loaders #11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bcee114 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
ematipico
approved these changes
Aug 28, 2024
bluwy
approved these changes
Aug 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pass AstroConfig to content layer loaders, instead of AstroSettings. The main reason loaders needed settintgs was to access the config object, and AstroSettings is meant to be an internal object. The one exception is contentEntryTypes and dataEntryTypes, which are properties of settings. These are used by glob and other loaders that need to do rendering. As they're no longer available on settings, laoders are now passed a new object, which is
entryTypes, which is a Map of extension to entry type.Fixes PLT-2442
Testing
Tests updated
Docs
The experimental flag docs don't mention the settings object. The changeset highlights that this is a breaking change. I will also update the RFC.