Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix broken e2e test #11860

Merged
merged 1 commit into from
Aug 28, 2024
Merged

test: fix broken e2e test #11860

merged 1 commit into from
Aug 28, 2024

Conversation

ematipico
Copy link
Member

Changes

We have a specific one e2e that always fails. This PR fixes it

Testing

Tested locally, it passes now. CI should pass

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 33f6edf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 28, 2024
@ematipico ematipico merged commit fe80a2c into main Aug 28, 2024
13 checks passed
@ematipico ematipico deleted the chore/fix-e2e-teset branch August 28, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @matthewp @florian-lefebvre