Prevent usage of astro:content in the client #11827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5747564 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
matthewp
commented
Aug 23, 2024
| @@ -360,7 +372,7 @@ export async function generateLookupMap({ | |||
| const contentEntryType = contentEntryConfigByExt.get(extname(filePath)); | |||
| if (!contentEntryType) throw UnexpectedLookupMapError; | |||
|
|
|||
| const { id, slug: generatedSlug } = await getContentEntryIdAndSlug({ | |||
| const { id, slug: generatedSlug } = getContentEntryIdAndSlug({ | |||
There was a problem hiding this comment.
this is an unrelated change, but this await is on a sync function, so I removed.
Fryuni
reviewed
Aug 23, 2024
ematipico
reviewed
Aug 23, 2024
Co-authored-by: Emanuele Stoppa <[email protected]>
| if(isClient) { | ||
| // Empty exports is probably enough to break the build. | ||
| // If for some reason its being imported as a side-effect ala `import 'astro:content';` then throw an error message. | ||
| virtualModContents = `export {}; |
There was a problem hiding this comment.
Is this really needed? I think for astro:env I just throw without returning any content
There was a problem hiding this comment.
good point, removed
…ro into no-astro-content-in-client
florian-lefebvre
approved these changes
Aug 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs