Set external: true when loading astro config #11819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bcb2ab8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fryuni
approved these changes
Aug 22, 2024
matthewp
approved these changes
Aug 23, 2024
bluwy
dismissed
github-actions[bot]’s stale review
base branch is next (still awaiting docs review before merging)
sarah11918
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Sorry to be holding you up, @bluwy ! There's just one bit of one sentence that feels like it kind of got away from you. 😄 So just take a peek there and make sure it reads smoothly to you.
A couple of minor tweaks for readability, but good to go!
Co-authored-by: Sarah Rainsberger <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set
external: truewhen loading the astro config, this means Vite won't process any locally-linked dependencies anymore.Previously, locally-linked dependencies were automatically "no-externalized", however with
external: true, we disable this behaviour, so that all dependencies are "externalized" and hence imported by the nodejs runtime instead.closes #11621
Testing
Existing tests should pass.
Docs
Added a changeset explaining the change. I don't expect this to be a big breaking change, except potentially for integrations authors or monorepos, they may need to be aware of this change.