feat: remove the squoosh image service #11770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb00c39 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ematipico
approved these changes
Aug 19, 2024
bluwy
reviewed
Aug 19, 2024
scripts/cmd/build.js
Outdated
Comment on lines
114
to
124
| ...(copyWASM | ||
| ? [ | ||
| copy({ | ||
| resolveFrom: 'cwd', | ||
| assets: { | ||
| from: ['./src/assets/services/vendor/squoosh/**/*.wasm'], | ||
| to: ['./dist/assets/services/vendor/squoosh'], | ||
| }, | ||
| }), | ||
| ] | ||
| : []), |
There was a problem hiding this comment.
FYI I'm also changing this in main at https://github.com/withastro/astro/pull/11769/files#diff-3295a1ee2ce5eaeef758fac7b3eea7c5413dc7ccc11b42afcfbd25f0f384d753R68 that moves this for the build too, but looks like after this we can completely remove it, the --copy-wasm command, and esbuild-plugin-copy.
Letting you know in case you hit merge conflicts
bluwy
approved these changes
Aug 19, 2024
Merged
ematipico
pushed a commit
that referenced
this pull request
Aug 21, 2024
* feat: remove the squoosh image service * fix: build * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
* feat: remove the squoosh image service * fix: build * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
* feat: remove the squoosh image service * fix: build * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Feb 6, 2025
* feat: remove the squoosh image service * fix: build * chore: changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes the Squoosh image service. Since it's not the default anymore, the underlying library is unmaintained, it has memory leak issues, it's very slow, it's barely used, Sharp has WASM support now, generally has no purpose, etc. there's no big reasons to keep it around.
Testing
N/A
Docs
Will do!