Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code in internal scripts #11769

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Remove unused code in internal scripts #11769

merged 7 commits into from
Aug 20, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 19, 2024

Changes

  • Remove stats code as it doesn't seem to be used anymore. We can walk through the git history if we need it again.
  • Replace tiny-glob with fast-glob as that's what we use elsewhere
  • Remove del with fast-glob + fs.rm (works the same)
  • Remove svelte and tar handling. It doesn't seem like we rely on them anymore
  • Remove astro-scripts copy as it's not used anymore, it isn't copying anything except .wasm files, but we already handle that with astro-scripts dev/build --copy-wasm
  • Format /scripts/** with Biome (not .github/scripts yet)

Testing

Ran all the scripts manually, and the CI should pass

Docs

n/a

Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: 839fa87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 19, 2024
@bluwy
Copy link
Member Author

bluwy commented Aug 19, 2024

Looks like I need to fix the windows e2e fail first before merging

@bluwy bluwy merged commit 1fd84b6 into main Aug 20, 2024
14 checks passed
@bluwy bluwy deleted the cleanup-scripts branch August 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants