Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functionPerRoute option #11714

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Remove functionPerRoute option #11714

merged 9 commits into from
Aug 19, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 14, 2024 •
edited
Loading

Changes

  • Removes the functionPerRoute and all splitting logic as well as tests.
  • This feature only impacts the Vercel adapter which is the only that supported this feature.
  • Adapter repo checked and nothing to do there.

Testing

  • Tests updated as needed

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 988fa03

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Aug 14, 2024
@github-actions github-actions bot added the semver: major Change triggers a `major` release label Aug 15, 2024
github-actions[bot]
github-actions bot requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@matthewp matthewp marked this pull request as ready for review August 15, 2024 14:11
@github-actions github-actions bot removed the pr: docs A PR that includes documentation for review label Aug 19, 2024
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Aug 19, 2024
@matthewp matthewp merged commit 8a53517 into next Aug 19, 2024
12 of 14 checks passed
@matthewp matthewp deleted the remove-functionperroute branch August 19, 2024 14:31
@astrobot-houston astrobot-houston mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review semver: major Change triggers a `major` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @ematipico