Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro): Prevent prefetching of same urls with different hashes #11713

Merged
merged 4 commits into from
Aug 26, 2024
Merged

fix(astro): Prevent prefetching of same urls with different hashes #11713

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f49d1a6
fix(astro): prevent prefetching of the same urls with different hashes
voidfill Aug 14, 2024
a08ad13
add changeset
voidfill Aug 14, 2024
1544ae8
Update packages/astro/src/prefetch/index.ts
voidfill Aug 15, 2024
9faff0a
Update .changeset/nasty-ladybugs-whisper.md
voidfill Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nasty-ladybugs-whisper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Prevents prefetching of the same urls with different hahes.
5 changes: 5 additions & 0 deletions packages/astro/src/prefetch/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,11 @@ export interface PrefetchOptions {
* @param opts Additional options for prefetching.
*/
export function prefetch(url: string, opts?: PrefetchOptions) {
// Remove url hash to avoid prefetching the same URL multiple times
const urlObj = new URL(url, location.href);
urlObj.hash = '';
url = urlObj.toString();

const ignoreSlowConnection = opts?.ignoreSlowConnection ?? false;
if (!canPrefetchUrl(url, ignoreSlowConnection)) return;
prefetchedUrls.add(url);
Expand Down
Loading