-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make semicolon optional when detecting prerender
option
#11678
Conversation
🦋 Changeset detectedLatest commit: f038efd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This doesn't fix the repro for me, the problem is that the file is saved with CRLF endings, so the array after it's split by the regex looks like this: [
'false\r',
'export async function POST({ request }) {\r',
" console.log('POST REQUEST')",
'\r',
'\r',
' const form = await request.formData()',
'\r',
'\r',
" return new Response(JSON.stringify({ message: 'hello world' }))",
'\r',
'}'
] Adding a trailing |
.changeset/good-birds-clap.md
Outdated
'astro': patch | ||
--- | ||
|
||
Fixes a case where omitting a semicolon in the `prerender` option could throw an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also clarify that this is related to CRLF line endings.
Co-authored-by: Bjorn Lu <[email protected]>
Changes
Closes #11283
Testing
I tested it locally in a project of mine and it worked.
Existing CI should pass
Docs
N/A