Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make semicolon optional when detecting prerender option #11678

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

ematipico
Copy link
Member

Changes

Closes #11283

Testing

I tested it locally in a project of mine and it worked.

Existing CI should pass

Docs

N/A

Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: f038efd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ematipico ematipico requested a review from bluwy August 12, 2024 11:09
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 12, 2024
@bluwy
Copy link
Member

bluwy commented Aug 12, 2024

This doesn't fix the repro for me, the problem is that the file is saved with CRLF endings, so the array after it's split by the regex looks like this:

[
  'false\r',
  'export async function POST({ request }) {\r',
  "  console.log('POST REQUEST')",
  '\r',
  '\r',
  '  const form = await request.formData()',
  '\r',
  '\r',
  "  return new Response(JSON.stringify({ message: 'hello world' }))",
  '\r',
  '}'
]

Adding a trailing .trim() to remove that \r fixes it instead.

'astro': patch
---

Fixes a case where omitting a semicolon in the `prerender` option could throw an error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also clarify that this is related to CRLF line endings.

@ematipico ematipico merged commit 34da907 into main Aug 13, 2024
13 checks passed
@ematipico ematipico deleted the fix/prerender-detection branch August 13, 2024 10:20
@astrobot-houston astrobot-houston mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript API routes throw an error in hybrid rendering mode if set to render dynamically
3 participants