Actions: fix 500 on empty object for Vercel serverless #11634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8460456 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bholmesdev
commented
Aug 6, 2024
| @@ -65,15 +65,18 @@ async function handleAction(param, path, context) { | |||
| let body = param; | |||
| if (!(body instanceof FormData)) { | |||
| try { | |||
| body = param ? JSON.stringify(param) : undefined; | |||
There was a problem hiding this comment.
Fixes edge case where null is considered an empty body. null is valid JSON!
bluwy
approved these changes
Aug 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #11515. We discovered that Actions sets the
content-typetoapplication/jsoneven when the body isundefined. We setcontent-lengthto0for this case, but it seems some deployment platforms (Vercel) may remove this header if it detects an empty body.This fix removes the
content-typewhen no body is present.Testing
Docs
N/A