fix: audit incorrectly flagging images as above the fold (#10891) #11617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used �lement.offsetTop to find the y position of the image, which does not work when the element parent has a position: relative property. Instead, this uses �lement.getBoundingClientRect().y top get real y position of the image. There's one issue though, which is that getBoundingClientRect returns the position relative to the user's viewport, not the absolute position. So, add window.scrollY to the value to cancel that effect out, and you have the element's absolute position. https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY
🦋 Changeset detectedLatest commit: 5864c47 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
approved these changes
Aug 5, 2024
Princesseuh
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes Toolbar audit incorrectly flagging images as above the fold #10891
Previously used
element.offsetTopto find the y position of the image, which does not work when the element parent has a position: relative property.Instead, this uses
element.getBoundingClientRect().yto get the real y position of the image.There's one issue though.
getBoundingClientRectreturns the position relative to the user's viewport, not the absolute position.So, add window.scrollY to the value, and you have the element's absolute position.
Testing
No new tests were added as this is a trivial fix.
Docs
No docs needed for this fix.