fix(astro:content): add deprecated to getEntryBySlug & getDataEntryById
#11600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in the documentation, `getEntryBySlug` is deprecated in favor of `getEntry`. The same applies to `getDataEntryById`.
🦋 Changeset detectedLatest commit: 6b96ffc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ArmandPhilippot
changed the title
getEntryBySlug & getDataByEntrygetEntryBySlug & getDataEntryById
ArmandPhilippot
commented
Aug 2, 2024
delucis
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As noted in the documentation,
getEntryBySlugis deprecated in favor ofgetEntry. @delucis confirmed to me that this also applied togetDataEntryById.@deprecatedwarning on these two functions to help consumers migrate togetEntry.Testing
Locally, the JSDoc comment is correctly displayed when hovering the functions so I don't think another test is needed.
Docs
Docs is needed for
getDataEntryByIdbut this is already covered up by withastro/docs#8943