Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server islands with trailingSlash: always #11529

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Uses trailingSlash config in order to append a trailing slash to the island request. Only done when set to always.

Testing

  • Test updated

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 2c00d96

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Jul 22, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This reminds me that we want to revisit how trailing slash affects endpoints, which the current config does, but we may want endpoints to not be affected by it in the next major.

@matthewp matthewp merged commit 504c383 into main Jul 26, 2024
14 checks passed
@matthewp matthewp deleted the si-trailing-slash branch July 26, 2024 17:54
@astrobot-houston astrobot-houston mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants