fix(actions): resolve actions when there aren't user actions #11525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e7e6dd6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
changed the title
ematipico
force-pushed
the
fix/actions-import-meta-env
branch
from
545d2a7 to
db11cfe
Compare
ematipico
force-pushed
the
fix/actions-import-meta-env
branch
from
6277d08 to
7d58981
Compare
bholmesdev
approved these changes
Jul 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #11354
The issue was caused by the static analyzer of rollup, where it was trying to "understand" if
import(import.meta.env.ACTIONS_PATH)was a valid import. The functiongetActionwasn't even called, at all, during the build, because there were not actions to begin with.This issue was caused by the previous code's assumption that
actions/index.tswas always present, which was not the case. This issue would have surfaced once the experimental flag was removed.I fixed the issue by using the same approach we use in the middleware, where we have an internal virtual module, and we return a noop code in case the user didn't specify any action.
This PR also removes the need to have an environment variable.
Testing
Current CI should pass. I tested it locally by using the reproduction provided by the user.
Docs