Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin boxen to avoid JSON import #11483

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix: pin boxen to avoid JSON import #11483

merged 2 commits into from
Jul 17, 2024

Conversation

Princesseuh
Copy link
Member

Changes

Boxen 8 has a dependency that does a JSON import using an import attribute. This is fine, however our lowest supported versions of Node 18 and 20 don't support import attributes just yet.

Fix #11480

Testing

Tested manually

Docs

N/A

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: e604409

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 17, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the renovate bot to not provide another PR to update it

@Semkoo
Copy link

Semkoo commented Jul 17, 2024

We should update the renovate bot to not provide another PR to update it

I think by not placing the carets "^" in "boxen": "7.1.1", the bot should ignore no?

@Princesseuh Princesseuh merged commit 34f9c25 into main Jul 17, 2024
13 of 14 checks passed
@Princesseuh Princesseuh deleted the fix/pin-boxen branch July 17, 2024 18:58
@astrobot-houston astrobot-houston mentioned this pull request Jul 17, 2024
@bluwy
Copy link
Member

bluwy commented Jul 18, 2024

Ah thanks for figuring this out. Looks like boxen's new version ranges isn't correct 🤔

I think by not placing the carets "^" in "boxen": "7.1.1", the bot should ignore no?

The bot doesn't ignore and you need to manually ignore in the renovate config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build broken in Astro 4.11.6
4 participants