fix: avoid response rewrite inside the dev server #11477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 81e6aff The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
force-pushed
the
fix/rewrite-dev-server
branch
from
8885323 to
81e6aff
Compare
matthewp
approved these changes
Jul 17, 2024
Merged
ematipico
added a commit
that referenced
this pull request
Jul 18, 2024
* fix: avoid response rewrite inside the dev server * breakdown logic of reroute and rewrite
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #11306 once for all :)
The issue was specific to the dev server, where I didn't create a test for that.
I broke down the logic that was in place regarding the rerouting because it conflicts with the rewrite of the users. So I decided create a new header with its own logic
Testing
I created a test
Docs