-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(markdoc): Support markdown-it's typographer option #11450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b5b5034 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
Related to any renderer integration (scope)
label
Jul 10, 2024
schpet
force-pushed
the
markdoc-typographer
branch
from
July 10, 2024 15:31
0f0c013
to
38881ec
Compare
schpet
changed the title
Support markdoc-it's typographer option in markdoc
feat(markdoc): Support markdoc-it's typographer option
Jul 10, 2024
schpet
changed the title
feat(markdoc): Support markdoc-it's typographer option
feat(markdoc): Support markdown-it's typographer option
Jul 10, 2024
schpet
force-pushed
the
markdoc-typographer
branch
from
July 10, 2024 16:51
38881ec
to
d625c17
Compare
bluwy
reviewed
Jul 16, 2024
bluwy
reviewed
Jul 16, 2024
bluwy
approved these changes
Jul 16, 2024
Princesseuh
approved these changes
Jul 17, 2024
bholmesdev
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“good job”
Merged
ematipico
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Support markdoc-it's typographer option in markdoc * Update .changeset/forty-scissors-jog.md [skip ci] * Update .changeset/forty-scissors-jog.md [skip ci] * Fix typo in changeset --------- Co-authored-by: Bjorn Lu <[email protected]> Co-authored-by: Erika <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
this allows people to use markdown-it's typographer option:
the typographer option converts regular quotes to curly quotes. it's mentioned in the markdown-it readme.
Testing
a test was added to packages/integrations/markdoc/test/render.test.js confirming that regular quotes were replaced with the fancy variety.
Docs
it could use an additional section in the markdoc docs:
https://docs.astro.build/en/guides/integrations-guide/markdoc/#integration-config-options
/cc @withastro/maintainers-docs let me know if i should make a PR to add docs for this option to https://github.com/withastro/docs
Try it out
it took me a minute to figure out how to run my fork, but with these changes to the package.json i was able to run and deploy it: