Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(astro): clean sync #11415

Merged
merged 22 commits into from
Jul 17, 2024
Merged

feat(astro): clean sync #11415

merged 22 commits into from
Jul 17, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jul 4, 2024 •
edited
Loading

Changes

Testing

Existing tests should still pass

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e6993d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 4, 2024
@florian-lefebvre

This comment was marked as outdated.

Sign in to view
@florian-lefebvre florian-lefebvre marked this pull request as ready for review July 10, 2024 15:00
@florian-lefebvre florian-lefebvre requested a review from bluwy July 15, 2024 16:03
bluwy
bluwy reviewed Jul 16, 2024
View reviewed changes
packages/astro/src/core/sync/index.ts Outdated Show resolved Hide resolved
packages/astro/src/core/sync/index.ts Outdated Show resolved Hide resolved
@florian-lefebvre florian-lefebvre requested a review from bluwy July 17, 2024 14:17
bluwy
bluwy approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thanks for updating!

@florian-lefebvre florian-lefebvre merged commit e9334d0 into main Jul 17, 2024
13 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/clean-astro-sync branch July 17, 2024 15:38
@astrobot-houston astrobot-houston mentioned this pull request Jul 17, 2024
Merged
ematipico pushed a commit that referenced this pull request Jul 18, 2024
@florian-lefebvre @ematipico
feat(astro): clean sync (#11415)
b2e1728
@astrobot-houston astrobot-houston mentioned this pull request Jul 18, 2024
Merged
@bluwy bluwy mentioned this pull request Jul 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@ematipico ematipico ematipico approved these changes

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

astro:env does not generate .astro/env.d.ts in develoment mode
4 participants
@florian-lefebvre @matthewp @ematipico @bluwy