Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the build to Server Islands #11372

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Add support for the build to Server Islands #11372

merged 5 commits into from
Jul 2, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Adds support for the build.
  • Discovered islands are built using this.emitFile in the Vite/Rollup plugin.
  • The name / path pair are stored in a map and saved on the manifest.
  • From here it's the same as in dev mode.

Testing

  • Not yet, adding tests in a follow-up

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a86b43d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) labels Jun 28, 2024
@matthewp matthewp merged commit 9eaff96 into server-islands Jul 2, 2024
12 of 14 checks passed
@matthewp matthewp deleted the server-islands-build branch July 2, 2024 19:56
matthewp added a commit that referenced this pull request Jul 17, 2024
@matthewp @sarah11918
Server islands (#11305)
d495df5 
* Spike

* Server Islands

* Remove extra stuff

* Fix build, a little

* Fix build

* astro metadata can be undefined

* Add server:defer type

* Add support for the build to Server Islands (#11372)

* Add support for the build to Server Islands

* Use command instead

* editor tips

* Add comment about defaultRoutes

* Use renderChunk instead of generateBundle

* Server islands tests (#11405)

* Add support for the build to Server Islands

* Use command instead

* editor tips

* Add comment about defaultRoutes

* Use renderChunk instead of generateBundle

* Adds tests for server islands

* linting

* Pass slots to server islands (#11431)

* Require the experimental flag to use server islands (#11432)

* Require the experimental flag to use server islands

* Add flag to tests/examples

* Protect SSR against SI not being enabled

* Update the docs in the API ref

* Upgrade to compiler 2.9.0

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Fix lockfile

* Add a changeset

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update lockfile

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

---------

Co-authored-by: Sarah Rainsberger <[email protected]>
ematipico pushed a commit that referenced this pull request Jul 18, 2024
@matthewp @sarah11918 @ematipico
Server islands (#11305)
f058e33 
* Spike

* Server Islands

* Remove extra stuff

* Fix build, a little

* Fix build

* astro metadata can be undefined

* Add server:defer type

* Add support for the build to Server Islands (#11372)

* Add support for the build to Server Islands

* Use command instead

* editor tips

* Add comment about defaultRoutes

* Use renderChunk instead of generateBundle

* Server islands tests (#11405)

* Add support for the build to Server Islands

* Use command instead

* editor tips

* Add comment about defaultRoutes

* Use renderChunk instead of generateBundle

* Adds tests for server islands

* linting

* Pass slots to server islands (#11431)

* Require the experimental flag to use server islands (#11432)

* Require the experimental flag to use server islands

* Add flag to tests/examples

* Protect SSR against SI not being enabled

* Update the docs in the API ref

* Upgrade to compiler 2.9.0

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update packages/astro/src/@types/astro.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

* Fix lockfile

* Add a changeset

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* Update lockfile

* Update .changeset/five-rocks-vanish.md

Co-authored-by: Sarah Rainsberger <[email protected]>

---------

Co-authored-by: Sarah Rainsberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy left review comments

@ematipico ematipico ematipico left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewp @ematipico @bluwy