Fix attribute rendering for boolean values #11369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1dd7efb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Jun 28, 2024
github-actions
bot
added
the
pkg: integration
Merged
matthewp
added a commit
that referenced
this pull request
Jul 3, 2024
ematipico
pushed a commit
that referenced
this pull request
Jul 18, 2024
ematipico
pushed a commit
that referenced
this pull request
Jul 18, 2024
bluwy
added a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix #11342
Makes sure that normal attributes (e.g.
foobar={...}) and data attributes (.e.gdata-foobar={...}) renders correctly if giventrueorfalsevalues, which now they will render as="true"and="false"respectively. Only known HTML boolean attributes can omit the value.This refactor also enables reverting some fixes from #2538 as the base case covers the behaviour now.
Testing
Updated
astro-attrstestDocs
Added changeset. I think the changes are a bit subtle and shouldn't break anything, but do we want to to list an exhaustive example of how different values get rendered as what?