Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): update strategy when defining manually astro i18n middleware #11362

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ematipico
Copy link
Member

Changes

Closes #11355

The utility functions were still using the strategy = "manual". The fix updates strategy to the new value.

Testing

Added new test cases.

Docs

N/A

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 03a249a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 27, 2024
@ematipico ematipico force-pushed the fix/i18n-manual-routing branch from b48f7fd to 03a249a Compare June 27, 2024 13:34
@ematipico ematipico merged commit 93993b7 into main Jul 1, 2024
13 checks passed
@ematipico ematipico deleted the fix/i18n-manual-routing branch July 1, 2024 13:42
@astrobot-houston astrobot-houston mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n getRelativeLocaleUrl with manual routing strategy and i18n middleware returns wrong URL
2 participants