Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check experimental flag when using the rewrite function #11349

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

ematipico
Copy link
Member

Changes

Closes withastro/docs#8660

Testing

Manually tested

Docs

N/A

Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: 9aa98d2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 26, 2024
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but since it's duplicated, couldn't it be extracted to a shared function?

@ematipico
Copy link
Member Author

Looks good but since it's duplicated, couldn't it be extracted to a shared function?

Definitely, but I'd prefer to do it in another to reduce the changes.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thoughts as Florian too, and perhaps if it can do a

if (!this.pipeline.manifest.rewritingEnabled) {
  /// log error
  return
}

To prevent the indentation here and when we stabilize the feature, but not a huge blocker.

@ematipico ematipico merged commit 98d9ce4 into main Jun 26, 2024
13 checks passed
@ematipico ematipico deleted the fix/rewrite-missing-checks branch June 26, 2024 14:08
@astrobot-houston astrobot-houston mentioned this pull request Jun 26, 2024
ematipico added a commit that referenced this pull request Jul 18, 2024
* fix: check experimental flag when using the rewrite function

* apply feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite
3 participants