Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bug: removes type override from defineAction" #11335

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

ematipico
Copy link
Member

Reverts #11292

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: 913201f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 25, 2024
@bholmesdev
Copy link
Contributor

This was reverted due to incorrect types when the input parameter is omitted. The input should default to type unknown, but instead became unknown | FormData. This is because json was no longer assigned as the default.

We’ll need to take a different path to fix the bug in the original PR.

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js-on with the show!

@ematipico ematipico merged commit 4c4741b into main Jun 25, 2024
13 checks passed
@ematipico ematipico deleted the revert-11292-bug/defineaction-accept branch June 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants