Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Vercel Edge, include cookies set by Astro.cookies.set #11227

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Vercel Edge Middleware does a fetch call to the remote, but Astro.cookies need to be set on the response.
  • Addes the cookies similar to what happens inside of SSR.

Testing

  • New test added. Also re-enables a test that was previously skipped.

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 6c4ddb9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 10, 2024
@matthewp matthewp merged commit 24ce898 into main Jun 11, 2024
13 checks passed
@matthewp matthewp deleted the vercel-cookie branch June 11, 2024 13:32
@astrobot-houston astrobot-houston mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants