Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add firefox to the list of browsers to test #11036

Merged
merged 1 commit into from
May 15, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented May 14, 2024

Changes

Related to #10999

I tried to add the view transitions tests and dev toolbar tests for Firefox, but some scenarios fail.

cc @Princesseuh @martrapp

Testing

CI should pass

Docs

N/A

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 54bcb32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 14, 2024
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on fire ema

@ematipico ematipico merged commit e90c98f into main May 15, 2024
13 checks passed
@ematipico ematipico deleted the chore/e2e-firefox-tests branch May 15, 2024 07:06
@bluwy
Copy link
Member

bluwy commented May 15, 2024

Late to review this, but thanks for adding this Ema!

@martrapp
Copy link
Member

Happy to see Firefox being added to the list!
I will be looking into view transition e2es

@martrapp
Copy link
Member

#11093 adds view transition tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants