Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(solid): add support for devtools #10937

Merged
merged 12 commits into from
May 8, 2024
Merged

feat(solid): add support for devtools #10937

merged 12 commits into from
May 8, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented May 2, 2024 •
edited
Loading

Changes

Testing

Manually in the solid example

Docs

withastro/docs#8189

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2c58318

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) labels May 2, 2024
@florian-lefebvre florian-lefebvre added this to the 4.8.0 milestone May 2, 2024
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label May 5, 2024
@github-actions github-actions bot removed the pkg: example Related to an example package (scope) label May 5, 2024
sarah11918
sarah11918 reviewed May 5, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just getting ahead of the curve and matching the language of the Vue devtools PR here!

.changeset/olive-bags-drive.md Outdated Show resolved Hide resolved
@florian-lefebvre florian-lefebvre mentioned this pull request May 6, 2024
Merged
@florian-lefebvre
Copy link
Member Author

Failing test (sourcemap) looks unrelated, the fixture is not using solid at all

@florian-lefebvre florian-lefebvre marked this pull request as ready for review May 6, 2024 16:16
sarah11918
sarah11918 approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changeset for docs!

@ematipico ematipico removed this from the 4.8.0 milestone May 6, 2024
@ematipico
Copy link
Member

ematipico commented May 6, 2024 •
edited
Loading

@florian-lefebvre I removed the milestone. We use milestones only for core minors, and as a tool to manage PRs internally

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 8, 2024
bluwy
bluwy approved these changes May 8, 2024
View reviewed changes
.changeset/olive-bags-drive.md Outdated Show resolved Hide resolved
sarah11918
sarah11918 approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving updated changeset for docs! Thank you @florian-lefebvre !

@florian-lefebvre florian-lefebvre merged commit 7179930 into main May 8, 2024
5 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/solid-devtools branch May 8, 2024 14:48
@astrobot-houston astrobot-houston mentioned this pull request May 8, 2024
Merged
@shishkin
Copy link
Contributor

shishkin commented Jun 1, 2024

This has been a breaking change on vite@5. solid-devtools depends on outdated solid-start, which requires vite@4 as peer dependency.

@florian-lefebvre
Copy link
Member Author

@shishkin Can you open a new issue with a minimal repro and ping me? I'll have a look, I guess it will require an upstream fix

@shishkin shishkin mentioned this pull request Jun 9, 2024
Closed
1 task
@shishkin
Copy link
Contributor

shishkin commented Jun 9, 2024

@florian-lefebvre please see #11217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: solid Related to Solid (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@florian-lefebvre @ematipico @shishkin @matthewp @sarah11918 @bluwy