Rename to optimize.ignoreComponentNames
in MDX
#10884
Merged
+12
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@delucis suggested to rename the
optimize.customComponentNames
option tooptimize.ignoreComponentNames
, which I agree better reflect its usecase. Since this is an advanced option, I assume this shouldn't affect many projects and wouldn't be cumbersome to rename.Testing
Existing tests should work
Docs
I added a changeset describing the breaking change. The docs for
@astrojs/mdx
should also be updated, but I'll send a single PR about all the breaking changes later to the docs repo.