Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: markdown cannot find relative image path without leading ./ #10801

Merged
merged 6 commits into from
Apr 23, 2024
Merged

fix: markdown cannot find relative image path without leading ./ #10801

merged 6 commits into from
Apr 23, 2024

Conversation

rishi-raj-jain
Copy link
Contributor

Changes

  • As discovered in #10754, markdown required extending the same fix and separation of concerns between MD/X compilation and transformation.

Testing

  • Added a test that optimizes a png and checks for presence of webp in the built project.

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 56a1cb0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 17, 2024
@bluwy bluwy merged commit 204b782 into withastro:main Apr 23, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 23, 2024
Merged
@jasikpark
Copy link
Contributor

Sorry to comment on a closed PR, but it'd be great to get this in @astrojs/markdoc as well

@rishi-raj-jain rishi-raj-jain deleted the markdown-images branch April 24, 2024 14:19
@rishi-raj-jain
Copy link
Contributor Author

Sorry to comment on a closed PR, but it'd be great to get this in @astrojs/markdoc as well

Sure thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishi-raj-jain @jasikpark @bluwy