refactor: rename "config" file to "virtual" #10638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cf23fe The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bholmesdev
commented
Apr 1, 2024
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@astrojs/db": minor | |||
There was a problem hiding this comment.
Made minor since this renames an exports entry to runtime/virtual.js. This export is undocumented and is only used by Astro DB internally (not Astro core). Just being extra cautious with versioning.
ematipico
approved these changes
Apr 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
runtime/configfile has slowly evolved from holding the config helper (defineDb) to holding all static exports in the virtual module (sql,NOW, etc). Rename toruntime/virtualfor clarity.Testing
pnpm packand install in another project to ensure types still work.Docs