-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable sharp
libvips
cache.
#10616
Disable sharp
libvips
cache.
#10616
Conversation
🦋 Changeset detectedLatest commit: ab0ef29 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment that explains the new line of code?
Having a comment that explains this cache issue would give us a lot of context. Is there - also - an issue you can add to said comment?
One more thing, you'll need to add a changeset :)
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, wonky but it happens.
So, we were able fix a lot of our errors in
CompressAstro
withsharp
namely:and:
munmap_chunk(): invalid pointer
in these issues:
PlayForm/Compress#319
PlayForm/Compress#280
through:
PlayForm/Compress#319 (comment)
and:
PlayForm/Compress#280 (comment)
This
PR
disables thesharp
libvips
cache, as it errors when the file is too small and operations are happening too fast (runs into a race condition) - lovell/sharp#3935 (comment)