Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vercel node support status #10611

Merged

Conversation

jacobdalamb
Copy link
Contributor

Changes

  • Rename current to default
  • Add retiring status with removal: Date | string
  • Update the current supported node version to 20
  • Add info for retiring status

Testing

Docs

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: c18957b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 29, 2024
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Just a couple of non-blocking comments.

packages/integrations/vercel/src/serverless/adapter.ts Outdated Show resolved Hide resolved
packages/integrations/vercel/src/serverless/adapter.ts Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Lu <[email protected]>
.changeset/clever-houses-yawn.md Outdated Show resolved Hide resolved
@ematipico ematipico merged commit a9a3694 into withastro:main Apr 3, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 3, 2024
@jacobdalamb jacobdalamb deleted the fix/update-vercel-node-version branch April 3, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants