Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nft warnings behind verbose logging #10609

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Move nft warnings behind verbose logging #10609

merged 3 commits into from
Apr 1, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • These warnings are almost always false-positives. They happen when Vercel scans your source code looking for files to move over.
  • Keep the warnings but put them behind the Astro logger so they respect the --verbose flag and aren't seen normally.

Testing

Tested against example project

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: ffc9822

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 29, 2024
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome change!

packages/integrations/vercel/src/lib/nft.ts Outdated Show resolved Hide resolved
packages/integrations/vercel/src/lib/nft.ts Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 31590d4 into main Apr 1, 2024
13 checks passed
@matthewp matthewp deleted the verbose-msgs branch April 1, 2024 14:37
@astrobot-houston astrobot-houston mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants