Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance when --remote is omitted #10579

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Provide guidance when --remote is omitted #10579

merged 4 commits into from
Mar 27, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Mar 27, 2024

Changes

  • Expect a DATABASE_FILE during the build, which points to the production database, or error and explain that they probably wanted --remote.
  • Note that this restriction does not apply to static mode.

Testing

  • New tests added, testing both cases.

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: db47e23

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on error handling and naming. Re-mostly good to merge 👍

packages/db/src/core/integration/index.ts Outdated Show resolved Hide resolved
packages/db/src/core/integration/index.ts Outdated Show resolved Hide resolved
packages/db/src/core/integration/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL we expose Astro error

@matthewp matthewp merged commit f5df12c into main Mar 27, 2024
14 checks passed
@matthewp matthewp deleted the db-file branch March 27, 2024 19:20
@astrobot-houston astrobot-houston mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants