Fixes a style issue of client:only components in DEV mode during view transitions.
#10532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1e2403 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
martrapp
commented
Mar 22, 2024
Comment on lines
-710
to
+705
| const style = document.head.querySelector(`style[${VITE_ID}="${id}"]`); | ||
| const style = nextHead.querySelector(`style[${VITE_ID}="${id}"]`); |
There was a problem hiding this comment.
Instead of copying the styles from the previous page, we now copy from the iframe. This also works for non-persisted client:only components.
Comment on lines
-699
to
-703
| // Clear former persist marks | ||
| document.head | ||
| .querySelectorAll(`style[${PERSIST_ATTR}=""]`) | ||
| .forEach((s) => s.removeAttribute(PERSIST_ATTR)); | ||
|
|
There was a problem hiding this comment.
This was a remnant of an earlier approach.
matthewp
approved these changes
Mar 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixes #10466
Originally fixed for client:only components that use transition:persist in #8840.
It turns out that the styles were also missing when navigating back to pages with non-persisted
client:onlycomponents.Testing
e2e tests successful
Docs
bug fix, n.a.