Avoid generators when crawling module graph

[bluwy]

Changes

Avoid generators when crawling the module graph. Instead calculate the entire array directly and return it. In most cases, we're using the entire array so benefits of generators like able to bail out of iterating wasn't used.

Testing

existing tests should pass

In the astro docs repo, the Rollup build time went from 3m to 2m40s.

Docs

n/a. internal refactor.

[changeset-bot]

⚠️ No Changeset found

Latest commit: f4311ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[matthewp]

Needs a changeset. And this upsets me a lot.

[matthewp]

!bench memory

[github-actions]

PR Benchmark

Memory

	Elapsed time (s)	Memory used (MB)	Final memory (MB)
SSR build	2.98	91.40	130.32
Client build	0.08	0.35	130.51
Static generate	0.45	4.89	134.74

Main Benchmark

Memory

	Elapsed time (s)	Memory used (MB)	Final memory (MB)
SSR build	2.90	91.56	130.44
Client build	0.09	0.38	130.63
Static generate	0.44	4.99	134.90