Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): provide adapter locals to error pages #10427

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix(app): provide adapter locals to error pages #10427

merged 3 commits into from
Mar 13, 2024

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Mar 13, 2024 •
edited
Loading

Changes

Testing

  • Added to ssr-locals fixture.

Docs

  • Does not affect usage.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 56098df

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 13, 2024
@lilnasy lilnasy changed the title fix(app): provide locals to error pages fix(app): provide adapter locals to error pages Mar 13, 2024
@lilnasy lilnasy marked this pull request as ready for review March 13, 2024 17:46
@lilnasy lilnasy merged commit 128c7a3 into withastro:main Mar 13, 2024
13 checks passed
@lilnasy lilnasy deleted the fix/10421 branch March 13, 2024 20:32
@astrobot-houston astrobot-houston mentioned this pull request Mar 13, 2024
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloudflare runtime no longer accessible from 404.astro
3 participants
@lilnasy @matthewp @natemoo-re