fix(toolbar): add anchor element to interactive elements

[ematipico]

Changes

This PR adds a to the list of element that can be interactive.

Interactive elements are usually marked with the "widget" role. link role is a command role, which is a superclass that includes "widget".

Testing

I am happy to add a test with some guidance

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: 16537ef

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Princesseuh]

LGTM, just needs a changeset! You can add a test in e2e/dev-toolbar-audits.test.js if you want to, but I'm totally okay with not having one right now. We can make a full test suite for audits later

[HiDeoo]

Following the discussion from earlier today, I opened #10346.

According to this MDN reference, an anchor element is only considered interactive content if it has an href attribute:

Some elements belong to this category only under specific conditions:

<a>, if the href attribute is present
<audio>, if the controls attribute is present
<img>, if the usemap attribute is present
<input>, if the type attribute is not in the hidden state
<object>, if the usemap attribute is present
<video>, if the controls attribute is present

If my understanding is correct, the rules should check for the presence of the href attribute before considering the anchor element as interactive content (and same for the other elements with specific conditions). Any thoughts on this?

[Princesseuh]

Following the discussion from earlier today, I opened #10346.

According to this MDN reference, an anchor element is only considered interactive content if it has an href attribute:

Some elements belong to this category only under specific conditions:
<a>, if the href attribute is present
<audio>, if the controls attribute is present
<img>, if the usemap attribute is present
<input>, if the type attribute is not in the hidden state
<object>, if the usemap attribute is present
<video>, if the controls attribute is present

If my understanding is correct, the rules should check for the presence of the href attribute before considering the anchor element as interactive content (and same for the other elements with specific conditions). Any thoughts on this?

Ah yeah, the optimal solution would be to check in the match property. An helper could be made to make that easier to re-use.

[ematipico]

Changeset added. I suppose we can create the helper in another PR?

[Princesseuh]

Changeset added. I suppose we can create the helper in another PR?

Well it's not just the helper, the behaviour in this PR is incorrect since a a is only interactable under conditions

[ematipico]

All right, I'll add the logic tomorrow

[Princesseuh]

Seems fine!