Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround(node ssr): cancellation support for renderToAsyncIterable #10319

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Mar 4, 2024

Changes

Testing

  • Not sure about the conditions required for the error. Existing tests should pass.

Docs

  • Does not affect usage.

lilnasy added 2 commits March 4, 2024 15:14

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lilnasy Arsh

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lilnasy Arsh
Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: 2637bbe

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 4, 2024
.changeset/nice-pets-tie.md Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lilnasy lilnasy marked this pull request as ready for review March 4, 2024 15:31
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix, thanks!

@lilnasy lilnasy merged commit 19eccce into withastro:main Mar 4, 2024
13 checks passed
@lilnasy lilnasy deleted the fix/10301 branch March 4, 2024 15:45
@astrobot-houston astrobot-houston mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
3 participants