-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vercel): update @vercel/nft #10305
Conversation
🦋 Changeset detectedLatest commit: 3495d0f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview vercel-sharp-nft |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
@rochajulian can you try to set your |
Hey! Just to make sure i'm doing this right. I'd have to first uninstall the current version of vercel and then run npx astro add vercel@experimental--vercel-sharp-nft? Or how do i do it? I'm a bit new to this kinda stuff |
In your - "@astrojs/vercel": "your-current-version",
+ "@astrojs/vercel": "experimental--vercel-sharp-nft", Then run |
Thanks, I did it but am still getting the same issues on deployment.
and
|
Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
I think it doesn't hurt to bump the versions anyway. Since it doesn't seem to fix the sharp installation issue, should we update the PR description and changesets before merging? |
I think it actually fixes it, despite my comment above (it's better to refer to the issue in this case) but I'd like a confirmation from @lilnasy |
It fixes the sharp issue! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Florian for the prompt fix :)
* main: [ci] release (withastro#10337) Revert bad release (withastro#10336) [ci] release (withastro#10332) add missing changeset (withastro#10335) [ci] set `--tag` on release (withastro#10323) [ci] format add back data loss confirmation handling (withastro#10330) [ci] format fix(rendering): allow render instructions to propagate while rendering slots (withastro#10316) [ci] format fix: fixed an error in the vue component editor (withastro#10293) chore(vercel): update @vercel/nft (withastro#10305) Update turbo test dependsOn (withastro#10329) Add minimal @astrojs/db readme (withastro#10331)
* chore(vercel): update @vercel/nft * Update slimy-berries-mate.md
Changes
Testing
Tests should still pass
Docs
Bug fix, N/A