fix(toolbar): Make it so every built-in app can be closed by outside clicks #10220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 088fe25 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
commented
Feb 23, 2024
Comment on lines
+72
to
+74
| toolbar = page.locator('astro-dev-toolbar'); | ||
| appButton = toolbar.locator('button[data-app-id="astro:home"]'); | ||
| await appButton.click(); |
There was a problem hiding this comment.
This test actually didn't work, I'm not sure how it passed before, but it shouldn't have 🤔
Princesseuh
commented
Feb 23, 2024
|
|
||
| // If we have integration data, rebuild that part of the UI as well | ||
| // as it probably mean that the user had already open the app in this session (ex: view transitions) | ||
| if (integrationData) refreshIntegrationList(); |
There was a problem hiding this comment.
Moved this here because previously it'd refetch on every page load when using view transitions, we only want to fetch this once.
bluwy
approved these changes
Feb 26, 2024
ematipico
approved these changes
Feb 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Just making sure our handler to close on page clicks works in all our apps
Testing
Added a test
Docs
N/A