fix(preact): Fixes passing children to server-rendered components causing an error #10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5b21ed8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: preact
matthewp
approved these changes
Feb 22, 2024
github-actions
bot
added
pkg: example
Princesseuh
force-pushed
the
fix/preact-slots
branch
from
61d2796 to
5b21ed8
Compare
github-actions
bot
removed
pkg: example
Merged
log101
pushed a commit
to log101/astro
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
preact-render-to-string's last version has a regression, and it now returns an array of string instead of a string in some situations.Fix #10191
Testing
We actually have a test for this, but it didn't catch it since we were not using the latest version of the library, oops.
Docs
N/A