Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): Remove duplicate logging of errors #10197

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

Princesseuh
Copy link
Member

Changes

Since about a week ago, we were logging errors twice wrongly

Testing

Tested manually

Docs

N/A

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: ff6f5b2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 22, 2024
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@Princesseuh Princesseuh merged commit c856c72 into main Feb 22, 2024
13 checks passed
@Princesseuh Princesseuh deleted the fix/duplicate-error-log branch February 22, 2024 15:41
@astrobot-houston astrobot-houston mentioned this pull request Feb 22, 2024
log101 pushed a commit to log101/astro that referenced this pull request Feb 23, 2024
* fix(errors): Remove duplicate logging of errors

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants